EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

EIP-4824: Decentralized Autonomous Organizations submit

Open thelastjosh opened this issue 3 years ago • 20 comments

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

thelastjosh avatar Feb 17 '22 19:02 thelastjosh

A critical exception has occurred: Message: pr 4824 is already merged; quitting (cc @alita-moore, @mryalamanchi)

eth-bot avatar Feb 17 '22 19:02 eth-bot

This is interesting. Looking forward to learn from about it! I look forward to see EIP-1202 voting standard can interoperate in the DAO proposal.

xinbenlv avatar Feb 17 '22 22:02 xinbenlv

@thelastjosh can you update the PR title to include the EIP #

abcoathup avatar Feb 18 '22 22:02 abcoathup

Hi folks, just wanted to get this thing actually committed! Let me know if there are still any outstanding issues.

thelastjosh avatar Feb 27 '22 09:02 thelastjosh

It is currently waiting on review by @lightclient or @axic.

MicahZoltu avatar Feb 28 '22 05:02 MicahZoltu

Just wanted to ping this thread so it doesn't get lost! 🙏

thelastjosh avatar Mar 13 '22 02:03 thelastjosh

With respect to the JSON Schema, I wonder if ActivityLog has been considered using Event so it can be integrated the same way as other Event

xinbenlv avatar Mar 14 '22 21:03 xinbenlv

+1

On Tue, Apr 5, 2022 at 8:36 AM lightclient @.***> wrote:

@.**** commented on this pull request.

In EIPS/eip-4824.md https://github.com/ethereum/EIPs/pull/4824#discussion_r842940107:

@@ -0,0 +1,220 @@ +--- +eip: 4824 +title: Decentralized Autonomous Organizations

@thelastjosh https://github.com/thelastjosh this title will likely cause confusion among many people. I would like to request that you and your coauthors come up with a more specific title regarding the proposal.

— Reply to this email directly, view it on GitHub https://github.com/ethereum/EIPs/pull/4824#discussion_r842940107, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE4KRJINIFGUWFIVPIKUNDVDRMV7ANCNFSM5OVTLDHA . You are receiving this because you were mentioned.Message ID: @.***>

xinbenlv avatar Apr 05 '22 16:04 xinbenlv

Hi @lightclient just wanted to follow up on this.

thelastjosh avatar Apr 30 '22 11:04 thelastjosh

@MicahZoltu @lightclient Pinging for review.

thelastjosh avatar Jul 01 '22 00:07 thelastjosh

The commit 303de52a8a289405a56b45df8f0e787dec772223 (as a parent of 1debff965a0c79d2f566e2f35a3d7d2a0abe3cac) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 23 '22 06:07 github-actions[bot]

Okay, just went through all the requested changes, and added Furter (was triggering change to "Further") to the codespell! Thanks for the suggestions @Pandapip1

thelastjosh avatar Jul 23 '22 06:07 thelastjosh

The commit 0cec6063b1c05ca5e228e2a0517e03f18d16695b (as a parent of a8953c86c91d395e194bb1005067f54727a68d1e) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 23 '22 06:07 github-actions[bot]

The commit 160763659e243bdd1c8d60f4d510d38850f805d0 (as a parent of 7b2b6800eac566d7811d7183d3cdd6ff19133ae5) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 23 '22 07:07 github-actions[bot]

Just checking on this; I believe all blockers have been resolved. Let me know if there is anything else we need to do to get this published.

thelastjosh avatar Jul 25 '22 10:07 thelastjosh

The commit 0b03c2ee9e296b75e83bd45d3fcf503228f95cb3 (as a parent of 03fe3905ea0d77c74b1e4260d721c8e42efacdef) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 25 '22 12:07 github-actions[bot]

The commit 5915a310ad9feebb5e3c201fb809aaccc605baa5 (as a parent of 2a2bc9ab999d5dc49701c8ee6b14eb53126c042f) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 26 '22 11:07 github-actions[bot]

The commit 044acd681acb75dc686fcc7efd7d758c063f5137 (as a parent of f48e4c7ccb70624d0986dc4db823c09e70c2f0ec) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 27 '22 06:07 github-actions[bot]

Hi folks, just pinging this thread again. It seems to be stalled on something (codespell) that I can't control. In the meantime can we just add "Furter" to the codespell and merge this EIP, so it can at least enter draft stage?

thelastjosh avatar Aug 09 '22 04:08 thelastjosh

Hi @Pandapip1 @SamWilsn just noticed that this hasn't been merged, possibly due to the CodeSpell—wanted to follow up in case there's anything I can do. Thanks!

thelastjosh avatar Aug 22 '22 17:08 thelastjosh

I need to fix that bug :P

Pandapip1 avatar Sep 04 '22 01:09 Pandapip1

I need to fix that bug :P

Yeah, got spammed too. Also, yay! Finally merged. Thanks for shepherding this through @Pandapip1 🙏

thelastjosh avatar Sep 04 '22 02:09 thelastjosh