EIP-Bot icon indicating copy to clipboard operation
EIP-Bot copied to clipboard

EIP Bot should not require changes to the EIP file to modify EIP asset files

Open Pandapip1 opened this issue 3 years ago • 6 comments

See https://github.com/ethereum/EIPs/pull/5213

Example error:

file assets/eip-4907/contracts/ERC4907.sol is associated with EIP 4907 but there are no changes being made to corresponding EIP itself. To assure that the change is authorized by the relevant stake-holders, you must also make changes to the EIP file itself for the asset changes to be eligible for auto-merge

Pandapip1 avatar Jul 11 '22 17:07 Pandapip1

Question: is there a determined list for "normal rules for changing files in assets directory" ?

JEAlfonsoP avatar Sep 01 '22 23:09 JEAlfonsoP

is there a determined list for "normal rules for changing files in assets directory" ?

No, except for "the EIP has to be modified too."

Pandapip1 avatar Sep 02 '22 00:09 Pandapip1

To make this clear:

If any EIP-asset file is modified the EIP-Bot fails and requests authors to modify EIP-File itself ?

Is there some one else working on it ?

JEAlfonsoP avatar Sep 03 '22 12:09 JEAlfonsoP

No, nobody else it working on it. Go ahead!

Pandapip1 avatar Sep 03 '22 21:09 Pandapip1

Roger that, I will take a look on it..

JEAlfonsoP avatar Sep 04 '22 11:09 JEAlfonsoP

Nope, I'm not working on this.

SamWilsn avatar Sep 07 '22 14:09 SamWilsn