EIP-Bot icon indicating copy to clipboard operation
EIP-Bot copied to clipboard
verified publisher icon ethereum

Set `last-call-deadline` in the preamble before merging relevant pull requests

Open SamWilsn opened this issue 3 years ago • 13 comments

Originally from #55

Immediately before merging (IMO, ideally in the merge commit itself) set last-call-deadline in the preamble to 14 days after the merge date.

SamWilsn avatar Apr 20 '22 14:04 SamWilsn

I'm weakly against this one because last call is 14 days minimum, but unlimited maximum. Some authors like to give a longer last call, and core EIPs have a last call that runs until mainnet launch generally.

MicahZoltu avatar May 01 '22 10:05 MicahZoltu

Perhaps, if last call is missing automatically add it with 14 day window, if it is present then do nothing?

MicahZoltu avatar May 01 '22 10:05 MicahZoltu

How about:

  • If the last call deadline is missing: set it to merge date plus 14 days.
  • If the last call deadline is present, but sooner than 14 days plus the merge date: set it to merge date plus 14 days.
  • If the last call deadline is present, and is later than 14 days plus the merge date: leave untouched.

SamWilsn avatar May 06 '22 18:05 SamWilsn

could you please review this issue against 53. ? I believe 53 covers both, time and editors approval. If this is the case I will make a PR following Issue 53 to cover both.

JEAlfonsoP avatar May 07 '22 13:05 JEAlfonsoP

#53 is different. This suggestion is about making the bot add/adjust the last call deadline header field. #53 is about changing the number of editors required to change EIP-1.

MicahZoltu avatar May 08 '22 03:05 MicahZoltu

Ok. Roger that.

where would you like last-call-deadline to be added (or where normally is added, I do not see it in the EIP-1 template):

eip: title: <The EIP title is a few words, not a complete sentence> description: <Description is one full (short) sentence> author: <a comma separated list of the author's or authors' name + GitHub username (in parenthesis), or name and email (in angle brackets).
discussions-to: <URL> status: Draft type: <Standards Track, Meta, or Informational> category (*only required for Standards Track): <Core, Networking, Interface, or ERC> created: <date created on, in ISO 8601 (yyyy-mm-dd) format> requires (*optional): <EIP number(s)>

JEAlfonsoP avatar May 08 '22 13:05 JEAlfonsoP

After status line.

...
status: Last Call
last-call-deadline: YYYY-MM-DD
type: Core
...

MicahZoltu avatar May 09 '22 06:05 MicahZoltu

is anybody working on it ?

JEAlfonsoP avatar Sep 03 '22 12:09 JEAlfonsoP

Nope, go ahead! This might end up being a separate project though, so don't spend too much time on it.

Pandapip1 avatar Sep 03 '22 21:09 Pandapip1

Ok.

JEAlfonsoP avatar Sep 04 '22 11:09 JEAlfonsoP

How about:

  • If the last call deadline is missing: set it to merge date plus 14 days.
  • If the last call deadline is present, but sooner than 14 days plus the merge date: set it to merge date plus 14 days.
  • If the last call deadline is present, and is later than 14 days plus the merge date: leave untouched.

Question: Should EIP-Bot follows the above If's ?

JEAlfonsoP avatar Sep 05 '22 18:09 JEAlfonsoP

Yes, but see my comment https://github.com/ethereum/EIP-Bot/issues/65#issuecomment-1237530860

Pandapip1 avatar Sep 05 '22 23:09 Pandapip1

Roger. I will pass on this one either. Ty.

JEAlfonsoP avatar Sep 06 '22 00:09 JEAlfonsoP