EIP-Bot icon indicating copy to clipboard operation
EIP-Bot copied to clipboard

Set created date in the preamble immediately before merging new EIP pull requests

Open SamWilsn opened this issue 3 years ago • 9 comments

Originally from #55

Immediately before merging (IMO, ideally in the merge commit itself) set the created date in the preamble.

SamWilsn avatar Apr 20 '22 14:04 SamWilsn

I will PR this issue in the new FORK with a specific branch.

JEAlfonsoP avatar May 23 '22 22:05 JEAlfonsoP

You shouldn't be creating a new fork for every change. You want one fork with many branches.

MicahZoltu avatar May 24 '22 06:05 MicahZoltu

Thanks, this was before I deleted the FORk (one). I absolutely agree with you, that the new Fork (two), with a Branch for each Issue / PR is cleaner and simpler. Any idea or suggestion just shoot, I am here to learn and contribute.

JEAlfonsoP avatar May 24 '22 06:05 JEAlfonsoP

I believe this was closed by Sam before ?

JEAlfonsoP avatar Sep 03 '22 13:09 JEAlfonsoP

Nope?

Pandapip1 avatar Sep 03 '22 21:09 Pandapip1

I will take a look on it.

JEAlfonsoP avatar Sep 04 '22 11:09 JEAlfonsoP

EIP 1 template:

eip: title: <The EIP title is a few words, not a complete sentence> description: <Description is one full (short) sentence> author: <a comma separated list of the author's or authors' name + GitHub username (in parenthesis), or name and email (in angle brackets). discussions-to: status: Draft type: <Standards Track, Meta, or Informational> category (*only required for Standards Track): <Core, Networking, Interface, or ERC> created: <date created on, in ISO 8601 (yyyy-mm-dd) format> requires (*optional): <EIP number(s)>

Where do you want to include the created date ?

JEAlfonsoP avatar Sep 05 '22 18:09 JEAlfonsoP

Just a warning: I am making a separate tool to handle things like this. You're probably going to want to hold off on this, #64, and #66

Pandapip1 avatar Sep 05 '22 23:09 Pandapip1

Ok. Thanks for letting me know. I will pass on this one till you mention something else.

JEAlfonsoP avatar Sep 06 '22 00:09 JEAlfonsoP