superchain-ops icon indicating copy to clipboard operation
superchain-ops copied to clipboard

Add tests to check that Tenderly simulations don't revert.

Open blmalone opened this issue 9 months ago • 1 comments

As it stands, we can make code changes that break Tenderly simulations and we don't have any tests to tell us. We only find this out when we manually check the Tenderly links ourselves.

We should avoid the need for these discussions in the future:

  • https://github.com/ethereum-optimism/superchain-ops/pull/771#issuecomment-2742569180
  • https://github.com/ethereum-optimism/superchain-ops/pull/771#issuecomment-2743754543

One possible solution here is to make sure that the simulation doesn't revert. This might mean making a request to the tenderly API. Base contracts solves this by using their simulation function. However, we can't use this because we simulate a different way and it causes errors trying to simulate twice in the same EVM instance.

blmalone avatar Mar 21 '25 16:03 blmalone

#783 has a just command that will check all tasks against tenderly and fail if the task fails on tenderly. A different PR will get it on CI because some tasks are failing right now.

alcueca avatar Mar 22 '25 12:03 alcueca