superchain-ops icon indicating copy to clipboard operation
superchain-ops copied to clipboard

Support Finance ETH Transfers

Open prat-gpt opened this issue 11 months ago • 1 comments

Description

  • Use calldata values for getting encode transaction data, hash to approve and data to sign.
  • Add _balanceCheck in checkStateDiff function so that it can be overridden for Finance template.
  • Update Finance template logic for ETH transfers
  • Use Multicall3NoValueCheck for Finance template to support ETH transfers. Multicall3 contract cannot be used because, our tasks make delegate call to the multicall3 contract which further makes calls to targets using aggregate3Value function. This function has check: require(msg.value == valAccumulator, "Multicall3: value mismatch"); which will always fail because msg.value will always be zero when aggregate3Value is called using a delegate call.
  • Add Multicall3NoValueCheck deployment script.
  • Support readable amount format for ETH transfers

Metadata This PR is a part of Generic factor task.

prat-gpt avatar Mar 17 '25 13:03 prat-gpt

+1 to all of @ElliotFriedman's comments above

mds1 avatar Mar 17 '25 18:03 mds1