superchain-ops icon indicating copy to clipboard operation
superchain-ops copied to clipboard

AccountAccessParser Improvement

Open ElliotFriedman opened this issue 1 year ago • 1 comments

The AccountAccessParser library has lots of duplicate code looping over an array of VmSafe.AccountAccess and then subsequently looping over the array of storageAccesses contained inside each AccountAccess entry.

It would be nice to have a function that returns an array of all storage writes for a given AccountAccess array.

This function would allow us to remove duplicate code in functions getUniqueWrites and getStateDiffFor.

ElliotFriedman avatar Feb 24 '25 21:02 ElliotFriedman

This issue should not block mainnet as this is a small refactor/cleanup.

ElliotFriedman avatar Feb 24 '25 21:02 ElliotFriedman

Closing as AccountAccessParser has been refactored since this.

blmalone avatar Sep 24 '25 19:09 blmalone