superchain-ops icon indicating copy to clipboard operation
superchain-ops copied to clipboard

feat: make postCheck hook required

Open mds1 opened this issue 1 year ago • 2 comments

Currently the default _postCheck hook just logs a warning, to encourage people to implement it when creating tasks (example here). It would be ideal to have a require(false, "_postCheck not implemented") instead to force an implementation.

However, this is not currently implemented because it breaks the sc_rehearsal_1, sc_rehearsal_2, and sc_rehearsal_4 tasks which we want to keep in CI. Therefore the scope of this issue is:

  1. Give those tasks their own local solidity file, and have them implement an empty post-check.
  2. Change all _postCheck hooks to have a reverting, default implementation (using require(false) because this prevents solidity from emitting "unreachable code" warnings)

mds1 avatar Apr 17 '24 19:04 mds1

May I work on this issue?

ShubhSensei avatar Jun 20 '24 12:06 ShubhSensei

Yes, thank you! Just assigned you :)

mds1 avatar Jun 20 '24 21:06 mds1

This was completed by https://github.com/ethereum-optimism/superchain-ops/pull/266, thank you @ShubhSensei!

mds1 avatar Sep 27 '24 22:09 mds1