specs icon indicating copy to clipboard operation
specs copied to clipboard

Create spec for `Proxy.sol`

Open mds1 opened this issue 1 year ago • 1 comments

nit: it would be more ideal to have a spec for Proxy.sol and point to that, not sure if we do

Additionally, link to it from the OP Stack Manager specs page

Originally posted by @tynes in https://github.com/ethereum-optimism/specs/pull/236#discussion_r1655285108

mds1 avatar Jun 26 '24 18:06 mds1

The following functionality is consensus critical:

    modifier proxyCallIfNotAdmin() {
        if (msg.sender == _getAdmin() || msg.sender == address(0)) {
            _;
        } else {
            // This WILL halt the call frame on completion.
            _doProxyCall();
        }
    }

The || address(0) check in particular, where address(0) counts as having admin access. Hardfork system txs spoof address(0) to modify the predeploys

tynes avatar Jul 30 '24 02:07 tynes