optimistic-specs icon indicating copy to clipboard operation
optimistic-specs copied to clipboard

feature request: Add revert reason to FailedRelayedMessage event

Open transmissions11 opened this issue 4 years ago • 2 comments

Is your feature request related to a problem? Please describe. It's a real pain to debug L1->L2 messages that revert when they're relayed. This is because they just show a generic "evm execution reverted" error.

Example: https://kovan-optimistic.etherscan.io/tx/0x647991fe8282b4ddd1fdb8dd201c412adc6cbb92eba021f47be182a8a0dfe00e/advanced

Describe the solution you'd like Adding the error message into FailedRelayedMessage would allow block explorers or the watcher to alert users and devs of why the relay failed, making it easier to debug.

Describe alternatives you've considered Doing a trace and looking directly for the revert in l2geth and exposing this to etherscan?

transmissions11 avatar Aug 02 '21 16:08 transmissions11

Won't make it into 0.5.0 but this is a great candidate for 1.0.0.

smartcontracts avatar Nov 04 '21 19:11 smartcontracts

In bedrock the L1 to L2 messages have their own deposit txs, and the relay / entry-point on L2 is customizable. (there will likely be an encouraged default though that can replay failed deposit execution, and there this feedback is still useful). cc @maurelian

protolambda avatar Mar 28 '22 09:03 protolambda