optimistic-specs icon indicating copy to clipboard operation
optimistic-specs copied to clipboard

Published 20 hours ago • verified publisher icon ethereum-optimism

Consolidate Makefiles

Open maurelian opened this issue 3 years ago • 2 comments

Description: Decide if we want a makefile at the root of the repo or in the root of each project. See discussion in #197

maurelian avatar Feb 08 '22 20:02 maurelian

Reopening, the linked PR simply adds a Makefile in opnode but

  1. The makefiles are not consolidated into one
  2. There hasn't been a decision or even a discussion at whether we should keep them separate or consolidate them

norswap avatar Mar 23 '22 11:03 norswap

Discussion for office hours:

  • Want to lift opnode/contracts makefile to opnode makefile
  • Run recursive make in top-level makefile (and remove top-level makefile from building opnode)
  • Open Q: Use makefile for lint/test in CI or have duplicated commands
  • Open Q: Run make build as part of CI

trianglesphere avatar Mar 23 '22 16:03 trianglesphere