optimism icon indicating copy to clipboard operation
optimism copied to clipboard

VetoerSet Feature: request for PR guidance

Open xenoliss opened this issue 10 months ago • 0 comments

Hi there,

I'm Baptiste from the Base team. I've been working on adding the VetoerSet feature to the Optimism smart contracts to allow any of its members to perform a veto across the entire Superchain. I believe this has already been discussed, and the PR is almost ready to be sent. However, since this is my first one, I'm opening this issue for some guidance.

The PR adds new smart contracts in packages/contracts-bedrock (implementation + tests). The code is available here.

I am unsure about the following:

  1. Should I PR to the develop branch directly?
  2. Should I generate a changeset? (When trying for now, I encountered an error that I need to investigate further if that's needed.)
  3. Should I rebase on develop before sending the PR?

xenoliss avatar Mar 28 '24 09:03 xenoliss