optimism
optimism copied to clipboard
[DO NOT MERGE]: OPStackManager
This is a draft PR for discussion purposes only. This is untested code intended to convey an idea and there is a lot of room for improvement. The OpStackManager
is probably the closest approach to what we'd want, BlueprintStuff
was another approach I was trying out but is probably overkill post-MCP.
The high level idea is that we use a contract to manage chain deployments once chains are on MCP. Eventually, upgrades can be managed through here too, but this initial scope only includes deployments. All methods are thoroughly documented with comments, which will explain features and limitations of the current design
Semgrep found 6 sol-style-input-arg-fmt
findings:
- packages/contracts-bedrock/src/L1/OpStackManager.sol
Inputs to functions must be prepended with an underscore (_
)
Codecov Report
Attention: Patch coverage is 0%
with 76 lines
in your changes missing coverage. Please review.
Project coverage is 15.81%. Comparing base (
5137f3b
) to head (d11511e
). Report is 516 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #9985 +/- ##
============================================
- Coverage 28.25% 15.81% -12.45%
============================================
Files 165 124 -41
Lines 7295 5439 -1856
Branches 1335 1195 -140
============================================
- Hits 2061 860 -1201
+ Misses 5128 4504 -624
+ Partials 106 75 -31
Flag | Coverage Δ | |
---|---|---|
cannon-go-tests | ? |
|
chain-mon-tests | 27.14% <ø> (ø) |
|
common-ts-tests | ? |
|
contracts-bedrock-tests | 0.58% <0.00%> (-0.02%) |
:arrow_down: |
contracts-ts-tests | 12.25% <ø> (ø) |
|
core-utils-tests | ? |
|
sdk-next-tests | 40.54% <ø> (ø) |
|
sdk-tests | 40.54% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files | Coverage Δ | |
---|---|---|
...ckages/contracts-bedrock/src/L1/OPStackManager.sol | 0.00% <0.00%> (ø) |
Semgrep found 1 iterate-over-empty-map
finding:
Iteration over a possibly empty map Kinds
. This is likely a bug or redundant code
Definitely would love a design doc for this
Definitely would love a design doc for this
@tynes Good call, what do you think of a "3.9 L1 Contract Deployment" section of the specs to spec this out?
Definitely would love a design doc for this
@tynes Good call, what do you think of a "3.9 L1 Contract Deployment" section of the specs to spec this out?
This would be amazing! :D thank you
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.
Closing as stale, we now have a spec to base this off of: https://specs.optimism.io/experimental/op-stack-manager.html