optimism icon indicating copy to clipboard operation
optimism copied to clipboard

[DO NOT MERGE]: OPStackManager

Open mds1 opened this issue 10 months ago • 7 comments

This is a draft PR for discussion purposes only. This is untested code intended to convey an idea and there is a lot of room for improvement. The OpStackManager is probably the closest approach to what we'd want, BlueprintStuff was another approach I was trying out but is probably overkill post-MCP.

The high level idea is that we use a contract to manage chain deployments once chains are on MCP. Eventually, upgrades can be managed through here too, but this initial scope only includes deployments. All methods are thoroughly documented with comments, which will explain features and limitations of the current design

mds1 avatar Mar 27 '24 05:03 mds1

Semgrep found 6 sol-style-input-arg-fmt findings:

Inputs to functions must be prepended with an underscore (_)

Ignore this finding from sol-style-input-arg-fmt.

semgrep-app[bot] avatar Mar 27 '24 05:03 semgrep-app[bot]

Codecov Report

Attention: Patch coverage is 0% with 76 lines in your changes missing coverage. Please review.

Project coverage is 15.81%. Comparing base (5137f3b) to head (d11511e). Report is 516 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #9985       +/-   ##
============================================
- Coverage    28.25%   15.81%   -12.45%     
============================================
  Files          165      124       -41     
  Lines         7295     5439     -1856     
  Branches      1335     1195      -140     
============================================
- Hits          2061      860     -1201     
+ Misses        5128     4504      -624     
+ Partials       106       75       -31     
Flag Coverage Δ
cannon-go-tests ?
chain-mon-tests 27.14% <ø> (ø)
common-ts-tests ?
contracts-bedrock-tests 0.58% <0.00%> (-0.02%) :arrow_down:
contracts-ts-tests 12.25% <ø> (ø)
core-utils-tests ?
sdk-next-tests 40.54% <ø> (ø)
sdk-tests 40.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ckages/contracts-bedrock/src/L1/OPStackManager.sol 0.00% <0.00%> (ø)

... and 42 files with indirect coverage changes

codecov[bot] avatar Mar 27 '24 05:03 codecov[bot]

Semgrep found 1 iterate-over-empty-map finding:

Iteration over a possibly empty map Kinds. This is likely a bug or redundant code

Ignore this finding from iterate-over-empty-map.

semgrep-app[bot] avatar Mar 29 '24 21:03 semgrep-app[bot]

Definitely would love a design doc for this

tynes avatar Apr 02 '24 15:04 tynes

Definitely would love a design doc for this

@tynes Good call, what do you think of a "3.9 L1 Contract Deployment" section of the specs to spec this out?

mds1 avatar Apr 03 '24 01:04 mds1

Definitely would love a design doc for this

@tynes Good call, what do you think of a "3.9 L1 Contract Deployment" section of the specs to spec this out?

This would be amazing! :D thank you

tynes avatar Apr 03 '24 01:04 tynes

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Apr 20 '24 01:04 github-actions[bot]

Closing as stale, we now have a spec to base this off of: https://specs.optimism.io/experimental/op-stack-manager.html

mds1 avatar Jul 23 '24 20:07 mds1