optimism icon indicating copy to clipboard operation
optimism copied to clipboard

Duplicate Naming Convention between L1 `ProxyAdmin` and L2 `ProxyAdmin`

Open Ratimon opened this issue 11 months ago • 0 comments

Is your feature request related to a problem? Please describe.

I am now experimenting deploy OPstack 's smart contract and getting used to the solidity deployment script. I found that I need to deploy ProxyAdmin contract on L1 where save(string memory _name, address _deployed) is used behind the scene, and such saved address could be query later by getAddress(string memory _name).

So, when I write new logics in solidity script and try to use getAddress('ProxyAdmin') in order to query L1 address , it always wrongly ends up to L2 address in case the L1's ProxyAdmin has never been saved before.

This could lead to some confusion and difficulty, especially developing smart contract on top of OPstack.

Describe the solution you'd like

Change the convention of Predeploy contracts on L2 . eg. It must start with L2_XX like L2_ProxyAdmin.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

We could add new separate getter function with modified like getL2Address(string memory _name) Screenshot 2567-03-16 at 17 49 34

Ratimon avatar Mar 16 '24 10:03 Ratimon