Remove hardfork activation time overrides

[geoknee]

This is to be coordinated with https://github.com/ethereum-optimism/superchain-registry/pull/101. See that PR and linked issue for full context.

[coderabbitai[bot]]

[!WARNING]

Rate Limit Exceeded

@geoknee has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 28 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 3cb96ca26a0e59fcce5ed502e122e3912ae8c98c and 44b067ffec181a0a129dc0795d62e2420b9b183c.

Walkthrough

The update involves upgrading versions of the superchain and op-geth modules in the Go project, indicated by changes in the go.mod and go.sum files. Additionally, there's a significant alteration in how rollup configuration values are assigned in the superchain.go file, moving from calculated values based on chainID to direct assignments from the configuration. Furthermore, the testing configuration in chains_test.go is expanded to include a new devnet setup, enhancing testing capabilities.

Changes

Files	Change Summary
go.mod	Updated superchain version; modified replacement directive for go-ethereum with op-geth.
go.sum	Updated module versions and hashes for op-geth and superchain.
op-node/.../superchain.go	Removed logic for setting regolithTime and deltaTime based on chainID; updated value assignments from chConfig.
op-node/chaincfg/chains_test.go	Added configuration for oplabs-devnet-0-sepolia-dev-0; introduced a new detailed configuration variable.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 25.39%. Comparing base (6096d31) to head (44b067f).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #9642      +/-   ##
===========================================
- Coverage    28.52%   25.39%   -3.14%     
===========================================
  Files          164      101      -63     
  Lines         7214     3536    -3678     
  Branches      1324      575     -749     
===========================================
- Hits          2058      898    -1160     
+ Misses        5050     2607    -2443     
+ Partials       106       31      -75     

Flag	Coverage Δ
cannon-go-tests	82.29% <ø> (ø)
chain-mon-tests	?
common-ts-tests	?
contracts-bedrock-tests	0.60% <ø> (ø)
contracts-ts-tests	?
core-utils-tests	?
sdk-next-tests	?
sdk-tests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 63 files with indirect coverage changes

[geoknee]

This existing test would fail if the migration of the overrides (from here to superchain-registry) was not performed correctly: https://github.com/ethereum-optimism/optimism/blob/97b107b62a35b6e6188af4a800952f2932823a72/op-node/chaincfg/chains_test.go#L13-L22

[semgrep-app[bot]]

Semgrep found 2 golang_fmt_errorf_no_params findings:

• op-program/host/l2_client.go: L46
• op-chain-ops/cmd/check-ecotone/main.go: L647

No fmt.Errorf invocations without fmt arguments allowed

_{Ignore this finding from golang_fmt_errorf_no_params.}