optimism feat(contracts-periphery): Add Lisk testnet to PeripheryDeployConfig

Part of https://github.com/ethereum-optimism/ecopod/issues/816

Adds lisk testnet PeripheryDeployConfig.

Jan 26 '24 23:01 tremarkley

Semgrep found 1 sol-style-return-arg-fmt finding:

packages/contracts-bedrock/scripts/Artifacts.s.sol: L63

Named return arguments to functions must be appended with an underscore (_)

_{Ignore this finding from sol-style-return-arg-fmt.}

Jan 26 '24 23:01 semgrep-app[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 16.27%. Comparing base (e435fac) to head (cb033c8).

Additional details and impacted files

@@             Coverage Diff              @@
##           develop    #9218       +/-   ##
============================================
- Coverage    28.54%   16.27%   -12.27%     
============================================
  Files          164      122       -42     
  Lines         7192     5265     -1927     
  Branches      1322     1170      -152     
============================================
- Hits          2053      857     -1196     
+ Misses        5033     4333      -700     
+ Partials       106       75       -31

Flag	Coverage Δ
cannon-go-tests	`?`
chain-mon-tests	`27.14% <ø> (ø)`
common-ts-tests	`?`
contracts-bedrock-tests	`0.61% <ø> (ø)`
contracts-ts-tests	`12.25% <ø> (ø)`
core-utils-tests	`?`
sdk-next-tests	`41.94% <ø> (ø)`
sdk-tests	`41.94% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

see 42 files with indirect coverage changes

Jan 26 '24 23:01 codecov[bot]

Walkthrough

The recent update involves the addition of a new file to specify the chain ID for deployments, and modifications to the PeripheryDeployConfig contract. These modifications include the introduction of a new address for the Lisk L1 Bridge and an expansion of the addresses array to include this new bridge. These changes aim to enhance the contract's configuration capabilities and bridge connectivity.

Changes

Files	Change Summary
`packages/.../.chainId`	Added a new file containing the chain ID "4202".
`packages/.../PeripheryDeployConfig.s.sol`	Added `liskL1BridgeAddress` and expanded `smallFaucetsL1BridgeAddresses`. Updated initialization and retrieval functions.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Jan 29 '24 19:01 coderabbitai[bot]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Feb 13 '24 01:02 github-actions[bot]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Feb 29 '24 01:02 github-actions[bot]

Semgrep found 1 sol-style-return-arg-fmt finding:

packages/contracts-bedrock/scripts/Artifacts.s.sol: L53

Named return arguments to functions must be appended with an underscore (_)

_{Ignore this finding from sol-style-return-arg-fmt.}

Semgrep found 3 sol-style-malformed-revert findings:

packages/contracts-bedrock/src/legacy/LegacyERC20ETH.sol: L67, L61, L55

Malformed revert statement style.

_{Ignore this finding from sol-style-malformed-revert.}

Semgrep found 23 golang_fmt_errorf_no_params findings:

op-program/host/l2_client.go: L46
op-chain-ops/upgrades/l1.go: L716, L713, L710, L707, L704, L701, L589, L585, L507, L422, L418, L414, L410, L402, L398, L394, L288, L284, L204, L200, L122, L118

No fmt.Errorf invocations without fmt arguments allowed

_{Ignore this finding from golang_fmt_errorf_no_params.}

Semgrep found 9 ban-common-hex2bytes findings:

op-service/testutils/random.go: L109
op-node/rollup/derive/ecotone_upgrade_transactions.go: L37
op-challenger/game/fault/trace/alphabet/prestate.go: L13
op-chain-ops/deployer/testdata.go: L20, L18, L16, L14, L12
op-bindings/predeploys/eip4788.go: L14

Found banned use of common.Hex2Bytes. Use common.FromHex instead.

_{Ignore this finding from ban-common-hex2bytes.}

Semgrep found 1 missing-integrity finding:

op-node/cmd/stateviz/assets/index.html: L8

This tag is missing an 'integrity' subresource integrity attribute. The 'integrity' attribute allows for the browser to verify that externally hosted files (for example from a CDN) are delivered without unexpected manipulation. Without this attribute, if an attacker can modify the externally hosted resource, this could lead to XSS and other types of attacks. To prevent this, include the base64-encoded cryptographic hash of the resource (file) you’re telling the browser to fetch in the 'integrity' attribute for all externally hosted files.

_{Ignore this finding from missing-integrity.}

Semgrep found 4 ifs-tampering findings:

op-challenger/scripts/list_games.sh: L22, L19
op-challenger/scripts/list_claims.sh: L18, L15

The special variable IFS affects how splitting takes place when expanding unquoted variables. Don't set it globally. Prefer a dedicated utility such as 'cut' or 'awk' if you need to split input data. If you must use 'read', set IFS locally using e.g. 'IFS="," read -a my_array'.

_{Ignore this finding from ifs-tampering.}

Semgrep found 1 curl-pipe-bash finding:

packages/contracts-bedrock/scripts/verify-foundry-install.sh: L6

Data is being piped into bash from a curl command. An attacker with control of the server in the curl command could inject malicious code into the pipe, resulting in a system compromise. Avoid piping untrusted data into bash or any other shell if you can. If you must do this, consider checking the SHA sum of the content returned by the server to verify its integrity.

_{Ignore this finding from curl-pipe-bash.}

Semgrep found 5 todos_require_linear findings:

op-node/withdrawals/utils.go: L78
op-node/cmd/stateviz/main.go: L115
op-node/cmd/stateviz/assets/main.js: L89, L79, L62

Please create a GitHub ticket for this TODO.

_{Ignore this finding from todos_require_linear.}

Mar 04 '24 21:03 semgrep-app[bot]

Semgrep found 23 golang_fmt_errorf_no_params findings:

op-program/host/l2_client.go: L46
op-chain-ops/upgrades/l1.go: L716, L713, L710, L707, L704, L701, L589, L585, L507, L422, L418, L414, L410, L402, L398, L394, L288, L284, L204, L200, L122, L118

No fmt.Errorf invocations without fmt arguments allowed

_{Ignore this finding from golang_fmt_errorf_no_params.}

Semgrep found 9 ban-common-hex2bytes findings:

op-service/testutils/random.go: L109
op-node/rollup/derive/ecotone_upgrade_transactions.go: L37
op-challenger/game/fault/trace/alphabet/prestate.go: L13
op-chain-ops/deployer/testdata.go: L20, L18, L16, L14, L12
op-bindings/predeploys/eip4788.go: L14

Found banned use of common.Hex2Bytes. Use common.FromHex instead.

_{Ignore this finding from ban-common-hex2bytes.}

Mar 04 '24 21:03 semgrep-app[bot]

feat(contracts-periphery): Add Lisk testnet to PeripheryDeployConfig

Codecov Report

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

CodeRabbit Configration File (`.coderabbit.yaml`)