optimism icon indicating copy to clipboard operation
optimism copied to clipboard

specs: define Regolith upgrade changes to deposit transactions

Open protolambda opened this issue 2 years ago • 2 comments

Description

This defines the Regolith upgrade changes to deposits, excluding the exact activation condition of the hardfork.

Changes:

  • Clarify the transaction API field additions when clarifying the transaction-type field additions.
  • The EVM processing part defines the behavior in terms of differences with standard EVM behavior, to make differences clear and avoid inaccuracies (we do not want to re-specify the whole EVM)
  • Define the post-processing with receipt depositNonce addition with Regolith.
  • Define the gas-used changes of Regolith
  • Define the extended Deposit receipt type
  • Define the changes to L1-info deposit derivation

This also corrects some inaccuracies that remain from previous pre-Goerli deposit changes:

  • The deposit-tx type follows the standard typing pattern. End summer last year I believe we removed the sub-version thing, and the spec still mentioned it.
  • The isSystemTx boolean was referenced in different parts of the spec, but not in the main deposit transaction definition.
  • The contract-deployment case was mentioned, but the processing section was only handling EVM calls.

Additional context

See design-doc for additional context. The Regolith hardfork basically addresses inaccuracies in the meta-data of the deposit processing (gas usage in receipt, system-tx metering change, nonce data).

Metadata

Fix CLI-3512

protolambda avatar Feb 25 '23 02:02 protolambda

⚠️ No Changeset found

Latest commit: 38f948d014f9e3cd0d93fa42491df8a42f8d6b79

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 25 '23 02:02 changeset-bot[bot]

Codecov Report

Merging #4977 (38f948d) into develop (bde2eac) will decrease coverage by 0.03%. The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4977      +/-   ##
===========================================
- Coverage    40.91%   40.89%   -0.03%     
===========================================
  Files          324      324              
  Lines        19677    19677              
  Branches       770      770              
===========================================
- Hits          8051     8047       -4     
- Misses       11017    11018       +1     
- Partials       609      612       +3     
Flag Coverage Δ
bedrock-go-tests 36.22% <ø> (-0.03%) :arrow_down:
contracts-bedrock-tests 49.74% <ø> (ø)
contracts-tests 98.86% <ø> (ø)
core-utils-tests 60.41% <ø> (ø)
dtl-tests 47.15% <ø> (ø)
fault-detector-tests 33.88% <ø> (ø)
sdk-tests 38.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-node/sources/batching.go 82.65% <0.00%> (-3.07%) :arrow_down:
op-node/heartbeat/service.go 55.26% <0.00%> (-2.64%) :arrow_down:

codecov[bot] avatar Feb 25 '23 02:02 codecov[bot]

Semgrep found 4 unchecked-type-assertion findings:

  • op-bindings/bindings/l1crossdomainmessenger.go: L587, L649
  • op-bindings/bindings/l2crossdomainmessenger.go: L587, L649

Unchecked type assertion.

Created by unchecked-type-assertion.

semgrep-app[bot] avatar Feb 27 '23 17:02 semgrep-app[bot]

Got a 502 bad-gateway on yarn task of integration tests. Will re-run from failed when CI is done

protolambda avatar Feb 27 '23 17:02 protolambda

This PR has been added to the merge queue, and will be merged soon.

mergify[bot] avatar Feb 28 '23 01:02 mergify[bot]

This PR is next in line to be merged, and will be merged as soon as checks pass.

mergify[bot] avatar Feb 28 '23 01:02 mergify[bot]

This PR is next in line to be merged, and will be merged as soon as checks pass.

mergify[bot] avatar Feb 28 '23 14:02 mergify[bot]

This PR is next in line to be merged, and will be merged as soon as checks pass.

mergify[bot] avatar Feb 28 '23 14:02 mergify[bot]