optimism icon indicating copy to clipboard operation
optimism copied to clipboard

op-node: Fix storage slot comment

Open mslipper opened this issue 2 years ago • 2 comments

The withdrawals mapping is the 0th storage slot, not the second.

Fixes CLI-3440

mslipper avatar Feb 24 '23 07:02 mslipper

⚠️ No Changeset found

Latest commit: f28099393491dcb4f800f8aa38dc6a2f5ce1b338

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 24 '23 07:02 changeset-bot[bot]

Codecov Report

Merging #4967 (f280993) into develop (280ec3f) will decrease coverage by 0.03%. The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4967      +/-   ##
===========================================
- Coverage    40.91%   40.89%   -0.03%     
===========================================
  Files          324      324              
  Lines        19677    19677              
  Branches       770      770              
===========================================
- Hits          8051     8047       -4     
- Misses       11017    11018       +1     
- Partials       609      612       +3     
Flag Coverage Δ
bedrock-go-tests 36.22% <0.00%> (-0.03%) :arrow_down:
contracts-bedrock-tests 49.74% <ø> (ø)
contracts-tests 98.86% <ø> (ø)
core-utils-tests 60.41% <ø> (ø)
dtl-tests 47.15% <ø> (ø)
fault-detector-tests 33.88% <ø> (ø)
sdk-tests 38.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-node/withdrawals/utils.go 4.16% <0.00%> (ø)
op-node/sources/batching.go 82.65% <0.00%> (-3.07%) :arrow_down:
op-node/heartbeat/service.go 55.26% <0.00%> (-2.64%) :arrow_down:

codecov[bot] avatar Feb 24 '23 07:02 codecov[bot]

This PR has been added to the merge queue, and will be merged soon.

mergify[bot] avatar Feb 27 '23 16:02 mergify[bot]

This PR is next in line to be merged, and will be merged as soon as checks pass.

mergify[bot] avatar Feb 27 '23 17:02 mergify[bot]