optimism
optimism copied to clipboard
op-batcher: Handle L2 Reorgs better
Description
A clear and concise description of the features you're adding in this pull request.
Tests
Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.
Invariants
For changes to critical code paths, please list and describe the invariants or key security properties of your new or changed code.
Additional context
Add any other context about the problem you're solving.
Metadata
- Fixes CLI-3326
⚠️ No Changeset found
Latest commit: ce62df906ce5a6e00675ad16b5cc3f804a4dbded
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
nevermind, just realized that the root cause of this not working is not found yet.
IDK why the test is failing in CI. It's passing locally.
This PR has been added to the merge queue, and will be merged soon.
This PR is next in line to be merged, and will be merged as soon as checks pass.
Codecov Report
Merging #4907 (ce62df9) into develop (29787f6) will increase coverage by
0.02%
. The diff coverage isn/a
.
Additional details and impacted files
@@ Coverage Diff @@
## develop #4907 +/- ##
===========================================
+ Coverage 40.94% 40.97% +0.02%
===========================================
Files 324 335 +11
Lines 19694 20466 +772
Branches 771 771
===========================================
+ Hits 8064 8386 +322
- Misses 11020 11440 +420
- Partials 610 640 +30
Flag | Coverage Δ | |
---|---|---|
bedrock-go-tests | 36.54% <ø> (+0.25%) |
:arrow_up: |
contracts-bedrock-tests | 49.93% <ø> (ø) |
|
contracts-tests | 98.86% <ø> (ø) |
|
core-utils-tests | 60.41% <ø> (ø) |
|
dtl-tests | 47.15% <ø> (ø) |
|
fault-detector-tests | 33.88% <ø> (ø) |
|
sdk-tests | 38.74% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
op-node/sources/batching.go | 82.65% <0.00%> (-3.07%) |
:arrow_down: |
op-batcher/batcher/channel_builder.go | 50.36% <0.00%> (ø) |
|
op-batcher/batcher/channel_manager.go | 40.60% <0.00%> (ø) |
|
op-batcher/cmd/main.go | 0.00% <0.00%> (ø) |
|
op-batcher/flags/flags.go | 100.00% <0.00%> (ø) |
|
op-batcher/batcher/utils.go | 0.00% <0.00%> (ø) |
|
op-batcher/rpc/api.go | 0.00% <0.00%> (ø) |
|
op-batcher/batcher/batch_submitter.go | 0.00% <0.00%> (ø) |
|
op-batcher/batcher/config.go | 0.00% <0.00%> (ø) |
|
op-batcher/batcher/txmgr.go | 0.00% <0.00%> (ø) |
|
... and 11 more |