optimism icon indicating copy to clipboard operation
optimism copied to clipboard

feat(cmn): better config parsing for BSV2

Open smartcontracts opened this issue 2 years ago • 4 comments

Description Updates config parsing for BaseServiceV2 to be more flexible and to allow for non-string input types. Makes it much easier to use BaseServiceV2 programmatically where you may want to supply the actual type instead of a string representation.

smartcontracts avatar Feb 09 '23 05:02 smartcontracts

🦋 Changeset detected

Latest commit: 78727a27421440e3e487f224c8d77e7c018df47a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@eth-optimism/replica-healthcheck Patch
@eth-optimism/message-relayer Patch
@eth-optimism/fault-detector Patch
@eth-optimism/chain-mon Patch
@eth-optimism/common-ts Minor
@eth-optimism/data-transport-layer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Feb 09 '23 05:02 changeset-bot[bot]

Codecov Report

Merging #4852 (78727a2) into develop (0bf643c) will decrease coverage by 4.52%. The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4852      +/-   ##
===========================================
- Coverage    39.44%   34.93%   -4.52%     
===========================================
  Files          270      194      -76     
  Lines        18320    15368    -2952     
  Branches       597       50     -547     
===========================================
- Hits          7227     5369    -1858     
+ Misses       10564     9472    -1092     
+ Partials       529      527       -2     
Flag Coverage Δ
bedrock-go-tests 34.71% <ø> (+0.04%) :arrow_up:
contracts-tests ?
core-utils-tests ?
dtl-tests 47.15% <ø> (ø)
fault-detector-tests 41.61% <ø> (ø)
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/fault-detector/src/service.ts 10.00% <ø> (ø)
packages/core-utils/src/optimism/fees.ts
packages/core-utils/src/common/misc.ts
packages/core-utils/src/external/ethers/index.ts
...racts/contracts/libraries/utils/Lib_MerkleTree.sol
...ontracts/libraries/resolver/Lib_AddressManager.sol
packages/core-utils/src/external/bcfg/index.ts
.../contracts/L2/messaging/L2StandardTokenFactory.sol
.../contracts/L2/predeploys/OVM_SequencerFeeVault.sol
...ore-utils/src/external/ethers/fallback-provider.ts
... and 68 more

codecov[bot] avatar Feb 09 '23 05:02 codecov[bot]

Is this ready for review?

tynes avatar Feb 10 '23 19:02 tynes

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Feb 25 '23 02:02 github-actions[bot]