optimism icon indicating copy to clipboard operation
optimism copied to clipboard

Remove duplication from CI Release workflow

Open gakonst opened this issue 3 years ago • 2 comments

The Problem

The release code is heavily duplicated, in order to allow for dynamically launching jobs, conditional on the job being output by changesets.

The main challenge is basically having conditional/dynamic logic in the matrix generation, so that the jobs generated only match the published packages (whereas now we have hard-coded the jobs and conditionally trigger them)

The Solution

Ideally, what we'd want, is a dynamic matric using publishedPackages which builds/pushes the services, and also "intelligently" builds the builder container only once (instead of having to re-build it for each service).

Another solution

Maybe we do not need to intelligently build the builder image, and just re-building it once per service is fine.

gakonst avatar Apr 16 '21 05:04 gakonst

Another solution

Maybe we do not need to intelligently build the builder image, and just re-building it once per service is fine.

This is an adjacent issue, but occasionally running the docker services after having built and run them results in an error returned by docker. @TransmissionsDev and I experienced this Friday and Saturday, and today.

platocrat avatar Apr 18 '21 23:04 platocrat

@platocrat please open a separate issue with the steps to reproduce (add a note if they need to be done "some" times to get the error) and the logs returned by docker!

gakonst avatar Apr 19 '21 05:04 gakonst