optimism icon indicating copy to clipboard operation
optimism copied to clipboard

op-e2e: Add invalid deposit test

Open trianglesphere opened this issue 3 years ago • 2 comments

Description

This test ensure that invalid deposits are stil included in the block. If these are somehow dropped, it would cause serious problems for consistency and potentially a loss of funds.

trianglesphere avatar Oct 25 '22 23:10 trianglesphere

⚠️ No Changeset found

Latest commit: 0af9e68e77908660306f8dc21285067336036485

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 25 '22 23:10 changeset-bot[bot]

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

mergify[bot] avatar Oct 25 '22 23:10 mergify[bot]

LGTM. Would be nice to add that 0-balance check however.

Added the 0-balance check.

trianglesphere avatar Oct 26 '22 18:10 trianglesphere

This PR has been added to the merge queue, and will be merged soon.

mergify[bot] avatar Oct 26 '22 20:10 mergify[bot]

This PR is next in line to be merged, and will be merged as soon as checks pass.

mergify[bot] avatar Oct 26 '22 20:10 mergify[bot]