optimism icon indicating copy to clipboard operation
optimism copied to clipboard

Published 20 hours ago • verified publisher icon ethereum-optimism

feat(ctb): explicit throw in trie get

Open smartcontracts opened this issue 3 years ago • 1 comments

Description Small refactor that has MerkleTrie.get throw explicitly when an element does not exist, rather than returning a non-existence boolean. Makes the code much cleaner. We need to review this change very carefully.

Tests Needs tests.

smartcontracts avatar Oct 25 '22 03:10 smartcontracts

🦋 Changeset detected

Latest commit: b6058a36f972b018322e4135c7cce063745e8509

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@eth-optimism/contracts-bedrock Minor
@eth-optimism/actor-tests Patch
@eth-optimism/sdk Patch
@eth-optimism/drippie-mon Patch
@eth-optimism/message-relayer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 25 '22 03:10 changeset-bot[bot]

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

mergify[bot] avatar Oct 28 '22 20:10 mergify[bot]

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

mergify[bot] avatar Nov 01 '22 21:11 mergify[bot]

How required are these changes?

tynes avatar Nov 03 '22 01:11 tynes

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Nov 17 '22 02:11 github-actions[bot]