optimism icon indicating copy to clipboard operation
optimism copied to clipboard

Adding support for publishing a linux/arm64 build to docker hub.

Open michaelneuder opened this issue 3 years ago • 2 comments

Description

https://github.com/ethereum-optimism/optimism/issues/3606 requests that linux/arm64 versions of the docker containers are published to docker hub. This PR modifies the docker-publish job template to be parameterized by a linux image and a a resource. It also creates a new job called op-node-publish-arm-dev which builds and publishes an arm64 version of the op-node container.

This is option 1 as described in https://github.com/ethereum-optimism/optimism/issues/3606#issuecomment-1283153169. See https://circleci.com/docs/using-arm/ for details on the arm execution environments provided by circle (namely note that there are fewer images with arm support https://circleci.com/docs/using-arm/#images-with-arm-support, which requires us to use a different ubuntu image than is used for the amd64 build).

Tests

I am not sure how the circleci workflow is triggered, which is why I only added the op-node container job (just to sanity check the method). If everything WAI, we can add the jobs for building arm versions of the batcher and proposer containers.

Additional context

Metadata https://github.com/ethereum-optimism/optimism/issues/3606

michaelneuder avatar Oct 21 '22 01:10 michaelneuder

⚠️ No Changeset found

Latest commit: 4e2324cd808658fa9efeacc0c88a6b30e999c554

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 21 '22 01:10 changeset-bot[bot]

Hey @michaelneuder, thanks for putting this pull request up! For us to feel comfortable with releasing arm64 support, we'd like to ensure our test pipelines run against both amd64 and arm64 platforms as well.

Unfortunately because CircleCI only offers VM executors for arm64 while our existing test jobs use docker images, this is not straightforward to re-tool.

The team is heads down on getting the bedrock release out right now and won't be able to take this on for quite some time. Again, thanks for your contribution and we will revisit this in the future.

zhwrd avatar Oct 24 '22 15:10 zhwrd