optimism icon indicating copy to clipboard operation
optimism copied to clipboard

Published 20 hours ago • verified publisher icon ethereum-optimism

op-batcher: Concurrently send transactions

Open trianglesphere opened this issue 3 years ago • 6 comments

Description

This is a simple hack to enable significantly higher throughput for lattice with op-craft.

Tests

I tested this locally by modifying the max tx size argument in the op-e2e tests & confirming that I see expected transaction sending behavior (by looking at the logs).

Metadata

  • Fixes ENG-2898

trianglesphere avatar Oct 15 '22 00:10 trianglesphere

⚠️ No Changeset found

Latest commit: 13002870cae709b83035c4c6ec16ea404de610f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 15 '22 00:10 changeset-bot[bot]

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

mergify[bot] avatar Oct 15 '22 00:10 mergify[bot]

We are guaranteed that the transactions will never revert if they make it into the mempool since there is no code at the account we are sending to. If we decide to add a contract that does the owner management instead of being able to dynamically + deterministically change the batch sender in the op-node, there is some complexity regarding reverted transactions, ie how do you know to resend the same batch if it happens to revert?

tynes avatar Oct 17 '22 17:10 tynes

If we decide to add a contract that does the owner management instead of being able to dynamically + deterministically change the batch sender in the op-node, there is some complexity regarding reverted transactions, ie how do you know to resend the same batch if it happens to revert?

There probably is, but we're ignoring it for now. This is only getting applied to the lattice branch and won't be brought into our production environment

trianglesphere avatar Oct 17 '22 17:10 trianglesphere

@mslipper we need to cut a new custom branch and incorporate this commit into it then.

trianglesphere avatar Oct 17 '22 23:10 trianglesphere

Turning into a draft to hide this until opcraft is over or we actually need this.

trianglesphere avatar Oct 20 '22 16:10 trianglesphere

Hey @trianglesphere! This PR has merge conflicts. Please fix them before continuing review.

mergify[bot] avatar Oct 28 '22 14:10 mergify[bot]

no longer needed.

trianglesphere avatar Oct 31 '22 19:10 trianglesphere