optimism icon indicating copy to clipboard operation
optimism copied to clipboard

feat(ctb): simplfy deploy scripts with dictator

Open smartcontracts opened this issue 3 years ago • 5 comments

Description Simplifies the deployment scripts by breaking them out into individual files. Also introduces a new FreshSystemDictator contract which is responsible for executing upgrades for fresh deployments.

smartcontracts avatar Oct 08 '22 19:10 smartcontracts

⚠️ No Changeset found

Latest commit: 94ce202b111e728892263c1974df3f8802edc2d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 08 '22 19:10 changeset-bot[bot]

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

mergify[bot] avatar Oct 08 '22 19:10 mergify[bot]

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

mergify[bot] avatar Oct 10 '22 03:10 mergify[bot]

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

mergify[bot] avatar Oct 21 '22 08:10 mergify[bot]

Is something in the .dockerignore that shouldn't be?

tynes avatar Oct 26 '22 17:10 tynes

I've had to clone a fresh repo and rebuild in the past to get the bindings to match for some reason, that might solve the issue if you cant get them to match 1:1

tynes avatar Oct 26 '22 19:10 tynes

Looking at the docker build issue

#44 [ethereumoptimism/l2geth:latest internal] load build context
#44 transferring context: 10.12MB 1.7s done
#44 ERROR: rpc error: code = Unavailable desc = transport is closing

#26 [ethereumoptimism/batch-submitter-service:latest builder 1/5] FROM docker.io/library/golang:1.18.0-alpine3.15@sha256:a2ca4f4c0828b1b426a3153b068bf32a21868911c57a9fc4dccdc5fbb6553b35
#26 CANCELED

#45 [ethereumoptimism/hardhat-node:latest 4/6] RUN yarn install && yarn cache clean
#0 0.705 yarn install v1.22.19
#0 0.727 info No lockfile found.
#0 0.755 [1/4] Resolving packages...
#45 CANCELED
------
 > [ethereumoptimism/l2geth:latest internal] load build context:
------
------
 > [ethereumoptimism/fault-detector:latest base  2/26] RUN apk --no-cache add curl     jq     python3     ca-certificates     git     make     gcc     musl-dev     linux-headers     bash     build-base     gcompat:
------
failed to solve: failed to compute cache key: extract requires an applier

tynes avatar Oct 26 '22 19:10 tynes

There might be something in the .dockerignore that matches something that is trying to be copied into the image? The exact error message has no hits on google

tynes avatar Oct 26 '22 19:10 tynes

This PR has been added to the merge queue, and will be merged soon.

mergify[bot] avatar Oct 26 '22 20:10 mergify[bot]

This PR is next in line to be merged, and will be merged as soon as checks pass.

mergify[bot] avatar Oct 26 '22 20:10 mergify[bot]