optimism icon indicating copy to clipboard operation
optimism copied to clipboard

Action-testing: extend user actor with withdrawal txs

Open protolambda opened this issue 3 years ago • 2 comments

Description

Withdrawals depend on the proposer working in action-testing. So this is now split from the main user-actor PR (#3628).

Depends on #3628

Tests

Work in progress. The test should be creating a withdrawal tx on L2, including it, then making a proposal on L1, including that, waiting the withdrawal period, and then completing the withdrawal.

protolambda avatar Oct 07 '22 05:10 protolambda

⚠️ No Changeset found

Latest commit: b05345d3b41699b0b33a4c463e02a8e0cea66cca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 07 '22 05:10 changeset-bot[bot]

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

mergify[bot] avatar Oct 07 '22 05:10 mergify[bot]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Oct 28 '22 02:10 github-actions[bot]

Will rebase this onto the proposer work so we can change it from draft to ready

protolambda avatar Nov 01 '22 09:11 protolambda

Rebased onto proposer-cleanup (#3805), we can now test withdrawals once the proposer actor makes its output root proposals.

protolambda avatar Nov 01 '22 13:11 protolambda

Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review.

mergify[bot] avatar Nov 02 '22 17:11 mergify[bot]

@trianglesphere updated, thanks

protolambda avatar Nov 03 '22 20:11 protolambda

This PR has been added to the merge queue, and will be merged soon.

mergify[bot] avatar Nov 03 '22 20:11 mergify[bot]

This PR is next in line to be merged, and will be merged as soon as checks pass.

mergify[bot] avatar Nov 03 '22 20:11 mergify[bot]