optimism icon indicating copy to clipboard operation
optimism copied to clipboard

op-node: Cleanup calldata source API

Open trianglesphere opened this issue 2 years ago • 2 comments

Description

This provides a new set of objects which provide the following API guarantees:

  • The opening of a data for a new L1 block will never fail.
  • If it failed to get transactions, it does so in the calls to Next.

This greatly simplifies usage of this object when constructing new data. If the node did not keep track of the internal state, the external users of this API would have to keep track of this state in a more complex way.

Tests

Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.

Additional context

Add any other context about the problem you're solving.

Metadata

  • Fixes ENG-2746

trianglesphere avatar Sep 22 '22 18:09 trianglesphere

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

mergify[bot] avatar Sep 22 '22 18:09 mergify[bot]

⚠️ No Changeset found

Latest commit: 8e611a03f9507a563e924e0ae7233db584c02b52

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Sep 22 '22 18:09 changeset-bot[bot]

This PR has been added to the merge queue, and will be merged soon.

mergify[bot] avatar Sep 26 '22 20:09 mergify[bot]

This PR is next in line to be merged, and will be merged as soon as checks pass.

mergify[bot] avatar Sep 26 '22 20:09 mergify[bot]