optimism
optimism copied to clipboard
feat(ctp): merge with contracts-governance
Description Removes the contracts-governance package and merges the remaining scripts, contracts, and tests into contracts-periphery.
🦋 Changeset detected
Latest commit: f1ed9c06dec77cc279de0796cb5eebe187f34263
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
| Name | Type |
|---|---|
| @eth-optimism/contracts-periphery | Patch |
| @eth-optimism/drippie-mon | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?
Semgrep found 10 detect-non-literal-fs-filename findings:
- packages/contracts-periphery/scripts/governance/create-airdrop-json.ts: L14, L28, L38
- packages/contracts-periphery/scripts/governance/create-distributor-json.ts: L16, L61
- packages/contracts-periphery/scripts/governance/deploy-distributor.ts: L24
- packages/contracts-periphery/scripts/governance/generate-merkle-root.ts: L15, L24
- packages/contracts-periphery/scripts/governance/multi-send.ts: L21
- packages/contracts-periphery/scripts/governance/test-claims.ts: L19
Detected function args enter fs module. An attacker could potentially control the location of this file, to include going backwards in the directory with '../'. To address this, ensure that user-controlled variables in file paths are validated.
🙈 From javascript.lang.security.audit.detect-non-literal-fs-filename.detect-non-literal-fs-filename.
Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.
Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.
Closing. Going to do this later.