optimism icon indicating copy to clipboard operation
optimism copied to clipboard

fix(dtl): retry correctly for non-block result

Open smartcontracts opened this issue 3 years ago • 4 comments

Description Fixes a small bug in the DTL that would cause the service to error out instead of retrying when eth_getBlockRange returned a non-block result. This would sometimes happen when the DTL was close to the tip and queried for a block that the target node did not have yet. This PR slows down the retries and properly detects bad results (anything except for an array is bad, including but not limited to "null" or "undefined").

Fixes #3341

smartcontracts avatar Sep 06 '22 21:09 smartcontracts

🦋 Changeset detected

Latest commit: cfe5b5b041c1b072aaee62ba38693c6494b0d0f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/data-transport-layer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Sep 06 '22 21:09 changeset-bot[bot]

Sigh, we'll need to sync something with this PR. Might take a while.

smartcontracts avatar Sep 06 '22 21:09 smartcontracts

Generally low priority

smartcontracts avatar Sep 06 '22 21:09 smartcontracts

Converting to draft until we sync a node with this fix.

mslipper avatar Sep 22 '22 02:09 mslipper

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Oct 07 '22 02:10 github-actions[bot]