optimism icon indicating copy to clipboard operation
optimism copied to clipboard

contracts-periphery: Citizen House Contracts

Open hansmrtn opened this issue 3 years ago • 6 comments

Description This PR moves the Citizen House contracts and its tests from Moonshot Collective to OP's monorepo.

Additional context The contracts build properly but fail to test due to a module import unrelated to the PRs changes.

Metadata

  • Adds Badge.sol to contracts-periphery/contracts/universal/citizen-house/
  • Adds BadgeAdmin.sol to contracts-periphery/contracts/universal/citizen-house/
  • Adds Badge.t.sol to contracts-periphery/contracts/foundry-tests/
  • Adds BadgeAdmin.t.sol to contracts-periphery/contracts/foundry-tests/
  • Adds IBadge.sol to contracts-periphery/contracts/universal/citizen-house/

With ❤️ from Gitcoin

hansmrtn avatar Jul 14 '22 01:07 hansmrtn

⚠️ No Changeset found

Latest commit: cccfd21d32b87836de8e1e9a0b273fa2b2e25b37

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jul 14 '22 01:07 changeset-bot[bot]

Is the module import the reason why a lot of tests are commented out?

tynes avatar Jul 14 '22 02:07 tynes

The tests are commented out because many are for an older contract version and are likely to fail.

Will update with the requested revisions!

hansmrtn avatar Jul 14 '22 02:07 hansmrtn

Hey @hmrtn! This PR has merge conflicts. Please fix them before continuing review.

mergify[bot] avatar Jul 26 '22 17:07 mergify[bot]

Ready for review 👍

hansmrtn avatar Aug 08 '22 17:08 hansmrtn

Could you squash the commits eventually?

tynes avatar Aug 09 '22 23:08 tynes

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Sep 02 '22 02:09 github-actions[bot]