optimism test: update succinct tests to follow our conventions

Description

Port tests for OPSuccint game and adapt to patterns in the monorepo

Tests

Port over test coverage for OPSuccinct and add test coverage

Metadata

Closes https://github.com/ethereum-optimism/optimism/issues/18461

Dec 01 '25 18:12 stevennevins

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 73.32%. Comparing base (5401e3a) to head (1250356).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #18452      +/-   ##
===========================================
+ Coverage    72.22%   73.32%   +1.10%     
===========================================
  Files          189      189              
  Lines        11163    11163              
===========================================
+ Hits          8062     8185     +123     
+ Misses        2955     2834     -121     
+ Partials       146      144       -2

Flag	Coverage Δ
cannon-go-tests-64	`66.58% <ø> (-0.82%)`	:arrow_down:
contracts-bedrock-tests	`77.13% <100.00%> (+2.18%)`	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...contracts-bedrock/src/dispute/zk/AccessManager.sol	`74.19% <100.00%> (+74.19%)`	:arrow_up:
...tracts-bedrock/src/dispute/zk/OptimisticZkGame.sol	`82.42% <100.00%> (ø)`

... and 6 files with indirect coverage changes

:rocket: New features to boost your workflow:

:snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
:package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Dec 03 '25 19:12 codecov[bot]

hi @stevennevins , sorry for the bake errors. I've fixed it in #18498, if you rebase your branch you should be good!

Dec 04 '25 12:12 falcorocks

hi @stevennevins , sorry for the bake errors. I've fixed it in #18498, if you rebase your branch you should be good!

No worries! I was trying to resolve separate issues with CI. Will rebase those changes today tho

Dec 04 '25 12:12 stevennevins

I think you only need strict versions pragmas for actual contracts. Libraries and abstract contracts, since they do not produce concrete abi artifacts, can have a fuzzy solc version specified. The actual contract that imports them will use a strict solc version. So the diff here can be much smaller.

Dec 04 '25 16:12 Inphi

I think you only need strict versions pragmas for actual contracts. Libraries and abstract contracts, since they do not produce concrete abi artifacts, can have a fuzzy solc version specified. The actual contract that imports them will use a strict solc version. So the diff here can be much smaller.

Yeah the diff kind of spiraled when it was causing failures in the semver-lock.json and some obscure issues with vm.getCode

Dec 04 '25 22:12 stevennevins