optimism icon indicating copy to clipboard operation
optimism copied to clipboard

all: Remove cannon-kona dgv2 feature flags

Open Inphi opened this issue 1 month ago • 3 comments

This PR removes the CANNON_KONA and DEPLOY_V2_DISPUTE_GAMES dev feature flags and makes their behavior the default.

Unresolved Issues

  • Should we maintain deploy scripts for V1 dispute games? These scripts may yet be useful for chains that haven't upgraded. While they will always be available in older op-deployer releases, it's quite convenient for the latest op-deployer to support them.

Inphi avatar Nov 07 '25 05:11 Inphi

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 71.89%. Comparing base (adf9b32) to head (8990804). :warning: Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #18208      +/-   ##
===========================================
- Coverage    75.52%   71.89%   -3.63%     
===========================================
  Files          189      189              
  Lines        11250    11163      -87     
===========================================
- Hits          8496     8026     -470     
- Misses        2610     2993     +383     
  Partials       144      144              
Flag Coverage Δ
cannon-go-tests-64 66.58% <ø> (ø)
contracts-bedrock-tests 74.90% <100.00%> (-5.61%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...es/contracts-bedrock/src/L1/OPContractsManager.sol 89.68% <100.00%> (-4.02%) :arrow_down:
...ock/src/L1/OPContractsManagerStandardValidator.sol 97.22% <100.00%> (-2.78%) :arrow_down:
...edrock/src/L1/opcm/OPContractsManagerContainer.sol 100.00% <ø> (ø)
...racts-bedrock/src/L1/opcm/OPContractsManagerV2.sol 95.62% <ø> (ø)
...es/contracts-bedrock/src/libraries/DevFeatures.sol 100.00% <ø> (ø)

... and 4 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 07 '25 05:11 codecov[bot]

This pr has been automatically marked as stale and will be closed in 5 days if no updates

opgitgovernance avatar Nov 26 '25 16:11 opgitgovernance

@Inphi carrying forward the scripts seems like a nice feature to me

stevennevins avatar Dec 10 '25 17:12 stevennevins