optimism icon indicating copy to clipboard operation
optimism copied to clipboard

op-acceptance-tests: add test to base gate for unsafe gossip / head progression

Open geoknee opened this issue 2 months ago • 3 comments

We recently realised that acceptance tests do not give us good coverage for unsafe head progression via p2p gossip. See, for example, https://github.com/ethereum-optimism/optimism/pull/17940 (a bug which wasn't caught by ATs) as well as a recent op-reth bug we only caught on devnet.

This test adds that coverage, and simply asserts that a) there are some non-sequencer verifier nodes and b) they catch up to the sequencer within a timeout period.

The test disables the sysgo batcher, because otherwise safe chain derivation would allow the test to pass even if gossip was broken. Therefore this test should not run against external networks.

I confirmed manually that introducing a bug, where op-node just rejects gossip payloads unconditionally, does indeed cause this test to fail.

geoknee avatar Oct 27 '25 12:10 geoknee

Similar tests exist in an unmerged PR here https://github.com/ethereum-optimism/optimism/pull/17751/files#diff-58dd5c61df58d9692977d4999df0077508b5575933bfe4e81c50a217bcdbe3ddR14 and here https://github.com/ethereum-optimism/optimism/pull/17751/files#diff-58dd5c61df58d9692977d4999df0077508b5575933bfe4e81c50a217bcdbe3ddR59

geoknee avatar Oct 27 '25 16:10 geoknee

This pr has been automatically marked as stale and will be closed in 5 days if no updates

opgitgovernance avatar Nov 14 '25 16:11 opgitgovernance

This pr has been automatically marked as stale and will be closed in 5 days if no updates

opgitgovernance avatar Dec 03 '25 16:12 opgitgovernance