optimism icon indicating copy to clipboard operation
optimism copied to clipboard

Dispute-mon checks output roots against multiple rollup nodes

Open pauldowman opened this issue 5 months ago • 1 comments

Dispute-mon takes multiple --rollup-rpc arguments, or one with a comma-separated list.

Implements logic described in https://github.com/ethereum-optimism/optimism/issues/11019, and keeps the assumption of assuming the output root was safe if safe head data isn't available.

Closes https://github.com/ethereum-optimism/optimism/issues/11019

pauldowman avatar Jun 17 '25 23:06 pauldowman

Codecov Report

Attention: Patch coverage is 83.80952% with 17 lines in your changes missing coverage. Please review.

Project coverage is 43.93%. Comparing base (7a0ab04) to head (43730eb). Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
op-dispute-mon/mon/service.go 0.00% 14 Missing :warning:
op-dispute-mon/flags/flags.go 0.00% 2 Missing :warning:
op-dispute-mon/config/config.go 75.00% 1 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (7a0ab04) and HEAD (43730eb). Click for more details.

HEAD has 12 uploads less than BASE
Flag BASE (7a0ab04) HEAD (43730eb)
cannon-go-tests-64 10 0
contracts-bedrock-tests 2 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #16490       +/-   ##
============================================
- Coverage    82.41%   43.93%   -38.49%     
============================================
  Files          158     1259     +1101     
  Lines         8828   107029    +98201     
============================================
+ Hits          7276    47021    +39745     
- Misses        1412    56366    +54954     
- Partials       140     3642     +3502     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...spute-mon/mon/extract/output_agreement_enricher.go 100.00% <100.00%> (ø)
op-dispute-mon/config/config.go 78.94% <75.00%> (ø)
op-dispute-mon/flags/flags.go 12.69% <0.00%> (ø)
op-dispute-mon/mon/service.go 0.00% <0.00%> (ø)

... and 1413 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 17 '25 23:06 codecov[bot]

Rebased and fixed conflict with the invalid block number check.

pauldowman avatar Jul 11 '25 23:07 pauldowman