optimism
optimism copied to clipboard
op-program: Bedrock contracts test setup fails due to incorrect Solady library mapping
Spearbit audit finding
Description The ForkLive.s.sol file imports the Solady library with the following.
import { LibString } from "solady/src/utils/LibString.sol";
However, the Foundry remapping already accounts for the src directory. This makes compilation through forge build fail.
Recommendation
Fix the import in ForkLive.s.sol.
diff --git a/packages/contracts-bedrock/test/setup/ForkLive.s.sol b/packages/contracts-bedrock/test/setup/ForkLive.s.sol
index 40e9c94e3..7ac455bd5 100644
--- a/packages/contracts-bedrock/test/setup/ForkLive.s.sol
+++ b/packages/contracts-bedrock/test/setup/ForkLive.s.sol
@@ -14,7 +14,7 @@ import { Deploy } from "scripts/deploy/Deploy.s.sol";
// Libraries
import { GameTypes, Claim } from "src/dispute/lib/Types.sol";
import { EIP1967Helper } from "test/mocks/EIP1967Helper.sol";
-import { LibString } from "solady/src/utils/LibString.sol";
+import { LibString } from "solady/utils/LibString.sol";
// Interfaces
import { IFaultDisputeGame } from "interfaces/dispute/IFaultDisputeGame.sol";
@Inphi - can you check if the PR above(https://github.com/ethereum-optimism/optimism/pull/15249) is the only thing we need to close this issue?
Can i work on this ?