optimism icon indicating copy to clipboard operation
optimism copied to clipboard

test: Default to enabling fault proofs

Open maurelian opened this issue 1 year ago • 3 comments

In order to have fault proofs be enabled by default in tests, without needing to modify the deploy config which is close to being deprecated, this PR replaces useFaultProofs with a new useLegacyContracts flag. Unless this flag is set to true, the fault proofs configuration will be deployed.

maurelian avatar Oct 16 '24 17:10 maurelian

Semgrep found 3 golang_fmt_errorf_no_params findings:

No fmt.Errorf invocations without fmt arguments allowed

Ignore this finding from golang_fmt_errorf_no_params.

semgrep-app[bot] avatar Oct 16 '24 18:10 semgrep-app[bot]

In favor of this

tynes avatar Oct 19 '24 13:10 tynes

Semgrep found 1 sol-style-notice-over-dev-natspec finding:

  • packages/contracts-bedrock/src/cannon/interfaces/IPreimageOracle.sol

Prefer @notice over @dev in natspec comments

Ignore this finding from sol-style-notice-over-dev-natspec.

Semgrep found 1 golang_fmt_errorf_no_params finding:

  • op-chain-ops/deployer/bootstrap/bootstrap.go

No fmt.Errorf invocations without fmt arguments allowed

Ignore this finding from golang_fmt_errorf_no_params.

semgrep-app[bot] avatar Oct 20 '24 00:10 semgrep-app[bot]

Merge activity

  • Oct 21, 9:27 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 21, 9:28 PM EDT: A user added this pull request to the GitHub merge queue with Graphite.

maurelian avatar Oct 22 '24 01:10 maurelian