optimism icon indicating copy to clipboard operation
optimism copied to clipboard

maint(ct): use L1Block interfaces in tests

Open smartcontracts opened this issue 1 year ago • 1 comments

Updates some tests to use the interfaces for L1Block and L1BlockNumber to cut down compile time.

smartcontracts avatar Oct 15 '24 19:10 smartcontracts

Semgrep found 4 golang_fmt_errorf_no_params findings:

No fmt.Errorf invocations without fmt arguments allowed

Ignore this finding from golang_fmt_errorf_no_params.

Semgrep found 1 math-random-used finding:

  • op-supervisor/supervisor/backend/source/head_monitor_test.go

Do not use math/rand. Use crypto/rand instead.

Ignore this finding from math-random-used.

Semgrep found 1 marshal-json-pointer-receiver finding:

  • op-supervisor/supervisor/backend/db/heads/types.go

MarshalJSON with a pointer receiver has surprising results: https://github.com/golang/go/issues/22967

Ignore this finding from marshal-json-pointer-receiver.

Semgrep found 1 err-nil-check finding:

superfluous nil err check before return

Ignore this finding from err-nil-check.

semgrep-app[bot] avatar Oct 17 '24 08:10 semgrep-app[bot]

Needs a rebase

tynes avatar Oct 21 '24 04:10 tynes

Semgrep found 2 sol-style-input-arg-fmt findings:

  • packages/contracts-bedrock/test/kontrol/proofs/utils/DeploymentSummaryFaultProofs.sol
  • packages/contracts-bedrock/test/kontrol/proofs/utils/DeploymentSummary.sol

Inputs to functions must be prepended with an underscore (_)

Ignore this finding from sol-style-input-arg-fmt.

semgrep-app[bot] avatar Oct 22 '24 13:10 semgrep-app[bot]