ethereum-optimism
Makefile: Fix executable command detection
$(command -v geth) is valid shell syntax, but it gets processed by make first, so that this never gets correctly executed by the shell. As a result, make install-geth and make install-eth2-testnet-genesis are always executed and not, as intended, just when the commands are not present.
The fix is easy: escape the dollar by duplicating it, so that make won't do anything and the correct command reaches the shell.
The CI jobs seem stuck. Should I do a new push to trigger them again or is there a better way to deal with it?
The CI jobs seem stuck. Should I do a new push to trigger them again or is there a better way to deal with it?
yeah. try rebasing on develop.
After rebasing on develop, I get a reproducible semgrep fail in CI:
Command failed with output:
fatal: Not a valid object name develop
Failed to run 'git cat-file -e develop'. Possible reasons: [...]
Can you try rebasing this one more time?
Done, but CI still fails with We cannot run this job using the selected resource class. Please check your configuration and try again..
Seems to be working now. This may have just needed authorization, though it's odd that the error message changed.