optimism icon indicating copy to clipboard operation
optimism copied to clipboard
verified publisher icon ethereum-optimism

Backport Granite Mainnet Release to v1.9.0

Open Inphi opened this issue 1 year ago • 5 comments

This PR contains a cherry-picked commit to fix incompatibilities with recent superchain-registry depedency. The second commit is what you should be more attentive to.

This is based on the op-geth release tag v1.101315.3-granite-mainnet, which is itself a backport of the mainnet release onto v1.101315.3 (refer to this diff for the changes)

Inphi avatar Aug 23 '24 01:08 Inphi

I take it all the alt-da changes is to preserve compatibility with changes in the superchain-registry?

ajsutton avatar Aug 23 '24 02:08 ajsutton

I take it all the alt-da changes is to preserve compatibility with changes in the superchain-registry?

caught me updating the PR description to mention this. Yup!

Inphi avatar Aug 23 '24 02:08 Inphi

op-geth devnet tests fail with Fatal: Failed to register the Ethereum service: incompatible state scheme, stored: path, provided: hash. I'm confused how this failure can be triggered by the changes done in this PR.

I remember that I've seen this once before in a PR of mine, but then I merged in latest develop and it was fixed. But this is not an option here. I think we can be pragmatic in this case and just completely disable and ignore the devnet tests for this PR, since this is just a backport.

sebastianst avatar Aug 23 '24 12:08 sebastianst

op-geth devnet tests fail with Fatal: Failed to register the Ethereum service: incompatible state scheme, stored: path, provided: hash. I'm confused how this failure can be triggered by the changes done in this PR.

I remember that I've seen this once before in a PR of mine, but then I merged in latest develop and it was fixed. But this is not an option here. I think we can be pragmatic in this case and just completely disable and ignore the devnet tests for this PR, since this is just a backport.

Yeah, thanks for flagging. I agree that we should ignore the devnet test.

Inphi avatar Aug 23 '24 13:08 Inphi

Something in the devnet test is using latest rather than a fixed version so old versions broke when the latest upstream geth got merged in. Agreed its safe to ignore that failure.

ajsutton avatar Aug 26 '24 23:08 ajsutton

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Sep 10 '24 01:09 github-actions[bot]