optimism icon indicating copy to clipboard operation
optimism copied to clipboard

op-challenger: clarify the output

Open DenseDenise opened this issue 1 year ago • 1 comments

For my first time to use ./bin/op-challenger list-claims The data name really confuses me, after I check the spces, I found the index means for Trace_Index, we should clarify it. And the parent for the root shouldn't be NIL, Because of the missing data, I mistakenly thought that Parent Depth was a whole data, not two data.

DenseDenise avatar Jul 12 '24 06:07 DenseDenise

image image

The reason for adding the hyphen is that without it, attributes with spaces in the middle can easily be misunderstood as two separate attributes rather than one whole attribute. As for the alignment, the arrangement on my CLI is basically the same as before, so there shouldn't be any misalignment. As shown in the picture. @ajsutton

DenseDenise avatar Jul 15 '24 09:07 DenseDenise

ah yeah I can see the new names still fit within the allocated space so the line format doesn't need changing. I'm definitely not a fan of adding in underscores - they just add more visual clutter. I'd also keep Value instead of Claim Value since all of the values are clearly from the claim.

I would also suggest just using Trace instead of Trace Index to keep it shorter - the values make it clear that it's a trace index. And a - instead of N/A for the root parent would reduce clutter a lot.

ajsutton avatar Jul 21 '24 23:07 ajsutton

ah yeah I can see the new names still fit within the allocated space so the line format doesn't need changing. I'm definitely not a fan of adding in underscores - they just add more visual clutter. I'd also keep Value instead of Claim Value since all of the values are clearly from the claim.

I would also suggest just using Trace instead of Trace Index to keep it shorter - the values make it clear that it's a trace index. And a - instead of N/A for the root parent would reduce clutter a lot.

Make sense. updated now

DenseDenise avatar Jul 22 '24 07:07 DenseDenise