optimism icon indicating copy to clipboard operation
optimism copied to clipboard

feat(challenger): `AsteriscKona` trace type

Open clabby opened this issue 1 year ago • 1 comments

Overview

Adds support for the new asterisc-kona game type in the op-challenger

clabby avatar Jul 12 '24 05:07 clabby

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.19%. Comparing base (0681bfc) to head (22c73b9).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #11140   +/-   ##
========================================
  Coverage    78.19%   78.19%           
========================================
  Files           28       28           
  Lines         2133     2133           
========================================
  Hits          1668     1668           
  Misses         405      405           
  Partials        60       60           
Flag Coverage Δ
cannon-go-tests 78.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Jul 12 '24 05:07 codecov[bot]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jul 29 '24 01:07 github-actions[bot]

I've opened a PR ontop of this to fix your suggestions @ajsutton to remove the embedding of Config within the VmConfig. There's a slight amount of duplication but it allows us not to have to alter the top level config.Config to create new fields to construct the various host configs. https://github.com/ethereum-optimism/optimism/pull/11309

refcell avatar Aug 01 '24 19:08 refcell