optimism icon indicating copy to clipboard operation
optimism copied to clipboard

op-supervisor: Include executing message info when storing logs

Open ajsutton opened this issue 1 year ago • 1 comments

Description

Parse ExecutingMessage events for logs and include it when storing in the database.

To make parsing the identifier straight forward, this changes the solidity to include Identifier in the event definition instead of first encoding it to bytes. This will conflict with the changes proposed in https://github.com/ethereum-optimism/specs/pull/254 which move to publishing the payload hash rather than the full payload but easy enough to resolve the difference. Will need to update the spec if we're happy with this change as well.

Tests

Added unit tests for parsing the log info.

Metadata

  • Fixes https://github.com/ethereum-optimism/optimism/issues/11024

ajsutton avatar Jul 09 '24 03:07 ajsutton

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 16.44%. Comparing base (f269f3f) to head (ebf13e8). Report is 189 commits behind head on develop.

:exclamation: There is a different number of reports uploaded between BASE (f269f3f) and HEAD (ebf13e8). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f269f3f) HEAD (ebf13e8)
cannon-go-tests 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #11104       +/-   ##
============================================
- Coverage    60.69%   16.44%   -44.25%     
============================================
  Files           20        8       -12     
  Lines         1781      535     -1246     
  Branches        71       71               
============================================
- Hits          1081       88      -993     
+ Misses         667      447      -220     
+ Partials        33        0       -33     
Flag Coverage Δ
cannon-go-tests ?
chain-mon-tests 27.14% <ø> (ø)
sdk-tests 16.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

codecov[bot] avatar Jul 09 '24 04:07 codecov[bot]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jul 24 '24 01:07 github-actions[bot]