optimism icon indicating copy to clipboard operation
optimism copied to clipboard

contracts-bedrock: cleanup deploy script

Open tynes opened this issue 1 year ago • 4 comments

Description

Makes the deploySafe function that doesn't broadcast internal. All of the public function do broadcast so this preserves the API. Also removes a redundent log

tynes avatar May 28 '24 12:05 tynes

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.26%. Comparing base (af2e326) to head (48d0b77). Report is 236 commits behind head on develop.

:exclamation: There is a different number of reports uploaded between BASE (af2e326) and HEAD (48d0b77). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (af2e326) HEAD (48d0b77)
chain-mon-tests 2 1
sdk-tests 2 1
cannon-go-tests 2 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #10665       +/-   ##
============================================
- Coverage    55.13%   39.26%   -15.88%     
============================================
  Files           37       27       -10     
  Lines         2900     1821     -1079     
  Branches       415      415               
============================================
- Hits          1599      715      -884     
+ Misses        1269     1106      -163     
+ Partials        32        0       -32     
Flag Coverage Δ
cannon-go-tests ?
chain-mon-tests 27.14% <ø> (ø)
sdk-tests 40.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

codecov[bot] avatar May 28 '24 13:05 codecov[bot]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jun 12 '24 01:06 github-actions[bot]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jun 27 '24 01:06 github-actions[bot]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jul 12 '24 01:07 github-actions[bot]