optimism icon indicating copy to clipboard operation
optimism copied to clipboard

upstream: attempt op-geth 1.13.12

Open axelKingsley opened this issue 1 year ago • 2 comments

This PR demonstrates that the monorepo works without modification against geth version v1.13.12

Because it does nothing besides update go.mod, it likely does not need to be merged. Instead, later version upgrades require real changes and do need to be merged.

axelKingsley avatar Apr 18 '24 14:04 axelKingsley

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.29%. Comparing base (4a3d3fb) to head (5406bdb). Report is 214 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #10205       +/-   ##
============================================
+ Coverage    42.40%   82.29%   +39.89%     
============================================
  Files           73       10       -63     
  Lines         4830     1073     -3757     
  Branches       766        0      -766     
============================================
- Hits          2048      883     -1165     
+ Misses        2676      159     -2517     
+ Partials       106       31       -75     
Flag Coverage Δ
cannon-go-tests 82.29% <ø> (ø)
chain-mon-tests ?
common-ts-tests ?
contracts-ts-tests ?
core-utils-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 63 files with indirect coverage changes

codecov[bot] avatar Apr 18 '24 14:04 codecov[bot]

Semgrep found 13 sol-style-notice-over-dev-natspec findings:

Prefer @notice over @dev in natspec comments

Ignore this finding from sol-style-notice-over-dev-natspec.

Semgrep found 1 dangerous-exec-command finding:

  • op-challenger/game/fault/trace/cannon/executor.go

Detected non-static command inside Command. Audit the input to 'exec.Command'. If unverified user data can reach this call site, this is a code injection vulnerability. A malicious actor can inject a malicious script to execute arbitrary code.

Ignore this finding from dangerous-exec-command.

semgrep-app[bot] avatar Apr 23 '24 14:04 semgrep-app[bot]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar May 16 '24 01:05 github-actions[bot]

Geth dep is at v1.13.15 / v1.101315.1-rc.2 already, closing this.

protolambda avatar May 16 '24 11:05 protolambda