optimism op-upgrade: bump superchain registry version and fix calls

Bumps the superchain registry to use the latest commit on main
In https://github.com/ethereum-optimism/optimism/pull/10117 legacy getters were removed from the portal, so we fix how op-upgrade fetches data to ensure it can still use the legacy getters to read from old implementations

Intentionally leaving this PR as draft as it requires a superchain registry bug to be fixed. While we know how to do the fix, it requires coordination between this repo and the superchain registry. Since we've already started MCP L1 upgrades before that fix, we avoid changing the process mid-upgrade, and continue to use this PR's branch for those upgrades

Apr 15 '24 21:04 mds1

Walkthrough

The recent updates aim to improve compatibility and stability in the codebase. The changes in the upgrades package ensure that the OptimismPortal function can gracefully handle legacy getters L2_ORACLE and SYSTEM_CONFIG, ensuring smooth operation across different contract versions. Furthermore, adjustments in chains_test.go optimize configurations by excluding specific entries like oplabs-devnet-0-sepolia-dev-0 to refine the testing environment.

Changes

File Path	Change Summary
`.../up-chain-ops/upgrades/l1.go`	Enhanced `OptimismPortal` to handle legacy getters `L2_ORACLE` and `SYSTEM_CONFIG` with improved error handling for compatibility with legacy contract interfaces.
`op-node/chaincfg/chains_test.go`	Optimized testing configurations by commenting out specific entries related to `oplabs-devnet-0-sepolia-dev-0`.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Apr 15 '24 21:04 coderabbitai[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.29%. Comparing base (2d354ac) to head (efd0b75). Report is 569 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop   #10160       +/-   ##
============================================
+ Coverage    42.40%   82.29%   +39.89%     
============================================
  Files           73       10       -63     
  Lines         4830     1073     -3757     
  Branches       766        0      -766     
============================================
- Hits          2048      883     -1165     
+ Misses        2676      159     -2517     
+ Partials       106       31       -75

Flag	Coverage Δ
cannon-go-tests	`82.29% <ø> (ø)`
chain-mon-tests	`?`
common-ts-tests	`?`
contracts-ts-tests	`?`
core-utils-tests	`?`
sdk-tests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

see 63 files with indirect coverage changes