lib-keccak icon indicating copy to clipboard operation
lib-keccak copied to clipboard

chore: bump Solidity to 0.8.25

Open smartcontracts opened this issue 1 year ago • 1 comments

Bumps the Solidity version to 0.8.25. Starting work on a larger migration of the entire Solidity codebase to 0.8.25 and this is one of the holdouts.

smartcontracts avatar Jul 23 '24 12:07 smartcontracts

Switching to draft for now, need to get approval on this

smartcontracts avatar Jul 24 '24 16:07 smartcontracts

Can this get revisited and approved? It's required for https://github.com/ethereum-optimism/optimism/issues/11527 to be implemented.

I think using loose versioning (^0.8.0) would be better in this case so it does not need to be changed in the future and can be used without a strict version constraint on other codebases

AmadiMichael avatar Sep 05 '24 21:09 AmadiMichael

Can this get revisited and approved? It's required for ethereum-optimism/optimism#11527 to be implemented.

I think using loose versioning (^0.8.0) would be better in this case so it does not need to be changed in the future and can be used without a strict version constraint on other codebases

We should use ^0.8.0 here for sure for the versions

tynes avatar Sep 05 '24 21:09 tynes