go-ethereum icon indicating copy to clipboard operation
go-ethereum copied to clipboard

Published 20 hours ago • verified publisher icon ethereum-optimism

cleanup: Remove OVM signer

Open smartcontracts opened this issue 4 years ago • 2 comments

Description

We're not using this code anymore, should be able to safely remove it.

Contributing Agreement

  • [x] I have read and understood the Optimism Contributing Guide and Code of Conduct and am following those guidelines in this pull request.

smartcontracts avatar Mar 11 '21 18:03 smartcontracts

@tynes we're based on Geth 1.9.10. The non-EIP155 signers are allowed there. They were only removed in Geth 1.10. Once we rebase to it, they will also be removed from our codebase, but for now I believe we should stick to minimizing the diff from 1.9.10. Also, the chainId is checked here in the OVM ECDSA Contract Account.

gakonst avatar Mar 27 '21 17:03 gakonst

This is a non-backwards compatible change meaning that historical sync depends on this - the RPC endpoint eth_sendrawethsigntransaction depends on the OVMSigner https://github.com/ethereum-optimism/go-ethereum/blob/b6ad0b3729dfde83f6f9d3122e8e8c5801790a47/internal/ethapi/api.go#L1661

This can only be removed if:

  • We regenesis
  • We have a sync that doesn't execute the transactions up to a certain height

We will no longer support the EthSign based transactions at some point, meaning we will need to sunset the functionality

We also have a hard requirement that the sequencer must reject transactions sent directly to it without a chainid

tynes avatar Mar 27 '21 17:03 tynes