ethereum-optimism.github.io icon indicating copy to clipboard operation
ethereum-optimism.github.io copied to clipboard

Update data.json for USDC sepolia

Open quanglam2807 opened this issue 9 months ago • 2 comments

New PR for https://github.com/ethereum-optimism/ethereum-optimism.github.io/pull/671

USDC on EVM testnet has been migrated from goerli towards sepolia in Jan 2024. This is to update the data.json to reflect that.

Description

USDC on EVM testnet has been migrated from goerli towards sepolia in Jan 2024. This is to update the data.json to reflect that.

Tests

Verified them through both internal verification and external etherscan verification. Links are here:

  1. Eth sepolia: https://sepolia.etherscan.io/address/0x1c7d4b196cb0c7b01d743fbc6116a902379c7238
  2. Base sepolia: https://sepolia.basescan.org/address/0x036cbd53842c5426634e7929541ec2318f3dcf7e
  3. OP sepolia: https://sepolia-optimism.etherscan.io/address/0x5fd84259d66cd46123540766be93dfe6d43130d7

Additional context

N/A

Metadata

quanglam2807 avatar Apr 26 '24 16:04 quanglam2807

Hi @quanglam2807,

It looks like the sepolia deployments do not follow the name "USD Coin" listed in the json file as well as the ethereum deployments, hence the validation script error

Is it possible to fix this with a fresh deployment? Might be hassle on Sepolia. Otherwise an easy fix here is to add an "overrides" section to the sepolia entries, overriding the name to "USDC"

hamdiallam avatar Apr 30 '24 17:04 hamdiallam

@quanglam2807

Here's a link with reference to how you can fix the failing CI with an override in the JSON. https://github.com/ethereum-optimism/ethereum-optimism.github.io?tab=readme-ov-file#per-token-overrides

wbnns avatar May 02 '24 00:05 wbnns

@quanglam2807

Since it's been a while and we haven't heard back, I'm closing this for now. Please let us know if you'd like to pursue the additional changes to resolve the outstanding issues on the PR and we can reopen. 👍

wbnns avatar May 08 '24 00:05 wbnns