ethereum-optimism.github.io icon indicating copy to clipboard operation
ethereum-optimism.github.io copied to clipboard

Published 20 hours ago • verified publisher icon ethereum-optimism

Add Base address for USDT token.

Open jbarber13 opened this issue 10 months ago • 4 comments

Description

Add Base address for USDT token.

Per 792 It would be preferable to avoid re-deploying as this contract is in use, and we would have to re-deploy other contracts as well, though it could potentially be done.

So is there a particularly strong argument for re-deploy? Or can we continue to use this deployment as we have been?

jbarber13 avatar Apr 17 '24 20:04 jbarber13

@jbarber13 your JSON isn't valid and you don't have an image. please see other prs. thanks!

rcbgr avatar Apr 25 '24 20:04 rcbgr

also, not sure that you can register USDT. are you with tether?

rcbgr avatar Apr 25 '24 20:04 rcbgr

@jbarber13 your JSON isn't valid and you don't have an image. please see other prs. thanks!

@rcbgr Can you elaborate on what is wrong with the JSON? It passes when I run the validation image

It should be using the same logo.png in the USDT folder?

jbarber13 avatar Apr 26 '24 23:04 jbarber13

@jbarber13

Hello, just confirming it looks like the JSON is all good. 👍 We're still reviewing this PR.

wbnns avatar May 01 '24 00:05 wbnns

@jbarber13

Hey. :) Similarly #792, do you have a link to any governance approval for this one as well?

wbnns avatar May 08 '24 00:05 wbnns

@jbarber13 Since it's been a while and we haven't heard back, closing this for now. Please let us know if you'd like to pursue the additional changes to resolve the outstanding issues on the PR and we can reopen. 👍

wbnns avatar May 14 '24 01:05 wbnns